11.2-RELEASE/efirt compile error

Discussion:

a***@WHISPER.SU

2018-07-01 09:24:51 UTC

hi everyone!

Trying to rebuild kernel from 11.1->11.2 RELEASE, till binary update
there was no problem at all with migrations but now im getting following
error building efirt module, tried to google a bit - nothing,
maybe someone already fixed it?

===> efirt (all)
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
-nostdinc   -DHAVE_KERNEL_OPTION_HEADERS -include
/usr/src/sys/amd64/compile/KERNEL/opt_global.h -I. -I/usr/src/sys
-fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-I/usr/src/sys/amd64/compile/KERNEL   -MD -MF.depend.efirt.o -MTefirt.o
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector
-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value
-Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999
-c /usr/src/sys/sys/amd64/amd64/efirt.c -o efirt.o
/usr/src/sys/sys/amd64/amd64/efirt.c:124:1: error: control reaches end
of non-void function
      [-Werror,-Wreturn-type]
}
^
/usr/src/sys/sys/amd64/amd64/efirt.c:186:1: error: static declaration of
      'efi_create_1t1_map' follows non-static declaration
efi_create_1t1_map(struct efi_md *map, int ndesc, int descsz)
^
/usr/src/sys/sys/efi.h:175:6: note: previous declaration is here
bool efi_create_1t1_map(struct efi_md *, int, int);
     ^
/usr/src/sys/sys/amd64/amd64/efirt.c:441:1: error: no previous prototype
for function
      'efi_get_time_locked' [-Werror,-Wmissing-prototypes]
efi_get_time_locked(struct efi_tm *tm)
^
/usr/src/sys/sys/amd64/amd64/efirt.c:463:12: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_lock(&resettodr_lock);
                  ^
/usr/src/sys/sys/amd64/amd64/efirt.c:465:14: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_unlock(&resettodr_lock);
                    ^
/usr/src/sys/sys/amd64/amd64/efirt.c:483:1: error: no previous prototype
for function
      'efi_set_time_locked' [-Werror,-Wmissing-prototypes]
efi_set_time_locked(struct efi_tm *tm)
^
/usr/src/sys/sys/amd64/amd64/efirt.c:505:12: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_lock(&resettodr_lock);
                  ^
/usr/src/sys/sys/amd64/amd64/efirt.c:507:14: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_unlock(&resettodr_lock);
                    ^
8 errors generated.
*** Error code 1

Stop.
make[2]: stopped in /usr/src/sys/modules/efirt
*** Error code 1

Stop.
make[1]: stopped in /usr/src/sys/modules
*** Error code 1

Stop.
make: stopped in /usr/src/sys/amd64/compile/KERNEL

part of kernel config:
device          vga                     # VGA video card driver
options         VESA                    # Add support for VESA BIOS
Extensions (VBE)

device          splash                  # Splash screen and screen saver
support

# syscons is the default console driver, resembling an SCO console
device          sc
options         SC_PIXEL_MODE           # add support for the raster
text mode

# vt is the new video console driver
device          vt
device          vt_vga
#device          vt_efifb

--
Anatoly

Konstantin Belousov

2018-07-01 11:15:18 UTC

Permalink

Post by a***@WHISPER.SU
hi everyone!
Trying to rebuild kernel from 11.1->11.2 RELEASE, till binary update
there was no problem at all with migrations but now im getting following
error building efirt module, tried to google a bit - nothing,
maybe someone already fixed it?
===> efirt (all)
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
-nostdinc   -DHAVE_KERNEL_OPTION_HEADERS -include
/usr/src/sys/amd64/compile/KERNEL/opt_global.h -I. -I/usr/src/sys
-fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-I/usr/src/sys/amd64/compile/KERNEL   -MD -MF.depend.efirt.o -MTefirt.o
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector
-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value
-Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999
-c /usr/src/sys/sys/amd64/amd64/efirt.c -o efirt.o
/usr/src/sys/sys/amd64/amd64/efirt.c:124:1: error: control reaches end
of non-void function
      [-Werror,-Wreturn-type]
}
^
/usr/src/sys/sys/amd64/amd64/efirt.c:186:1: error: static declaration of
      'efi_create_1t1_map' follows non-static declaration
efi_create_1t1_map(struct efi_md *map, int ndesc, int descsz)
^

There is no sys/amd64/amd64/efirt.c in 11.2 sources.

Post by a***@WHISPER.SU
/usr/src/sys/sys/efi.h:175:6: note: previous declaration is here
bool efi_create_1t1_map(struct efi_md *, int, int);
     ^
/usr/src/sys/sys/amd64/amd64/efirt.c:441:1: error: no previous prototype
for function
      'efi_get_time_locked' [-Werror,-Wmissing-prototypes]
efi_get_time_locked(struct efi_tm *tm)
^
/usr/src/sys/sys/amd64/amd64/efirt.c:463:12: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_lock(&resettodr_lock);
                  ^
/usr/src/sys/sys/amd64/amd64/efirt.c:465:14: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_unlock(&resettodr_lock);
                    ^
/usr/src/sys/sys/amd64/amd64/efirt.c:483:1: error: no previous prototype
for function
      'efi_set_time_locked' [-Werror,-Wmissing-prototypes]
efi_set_time_locked(struct efi_tm *tm)
^
/usr/src/sys/sys/amd64/amd64/efirt.c:505:12: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_lock(&resettodr_lock);
                  ^
/usr/src/sys/sys/amd64/amd64/efirt.c:507:14: error: use of undeclared
identifier
      'resettodr_lock'
        mtx_unlock(&resettodr_lock);
                    ^
8 errors generated.
*** Error code 1
Stop.
make[2]: stopped in /usr/src/sys/modules/efirt
*** Error code 1
Stop.
make[1]: stopped in /usr/src/sys/modules
*** Error code 1
Stop.
make: stopped in /usr/src/sys/amd64/compile/KERNEL
device          vga                     # VGA video card driver
options         VESA                    # Add support for VESA BIOS
Extensions (VBE)
device          splash                  # Splash screen and screen saver
support
# syscons is the default console driver, resembling an SCO console
device          sc
options         SC_PIXEL_MODE           # add support for the raster
text mode
# vt is the new video console driver
device          vt
device          vt_vga
#device          vt_efifb
--
Anatoly
_______________________________________________
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers

a***@WHISPER.SU

2018-07-01 12:16:56 UTC

Permalink

Konstantin, thanks for response, but it exists:

MD5 (./sys/amd64/amd64/efirt.c) = ddc9b6b4e79f12ee8588dbea3d2a010d

Post by Konstantin Belousov

There is no sys/amd64/amd64/efirt.c in 11.2 sources.

Oliver Pinter

2018-07-01 12:26:12 UTC

Permalink

Post by a***@WHISPER.SU
MD5 (./sys/amd64/amd64/efirt.c) = ddc9b6b4e79f12ee8588dbea3d2a010d

Nope: https://github.com/freebsd/freebsd/tree/releng/11.2/sys/amd64/amd64

Post by a***@WHISPER.SU

Post by Konstantin Belousov

Post by a***@WHISPER.SU
hi everyone!
Trying to rebuild kernel from 11.1->11.2 RELEASE, till binary update
there was no problem at all with migrations but now im getting following
error building efirt module, tried to google a bit - nothing,
maybe someone already fixed it?
===> efirt (all)
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
-nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include
/usr/src/sys/amd64/compile/KERNEL/opt_global.h -I. -I/usr/src/sys
-fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-I/usr/src/sys/amd64/compile/KERNEL -MD -MF.depend.efirt.o -MTefirt.o
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector
-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value
-Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999
-c /usr/src/sys/sys/amd64/amd64/efirt.c -o efirt.o
/usr/src/sys/sys/amd64/amd64/efirt.c:124:1: error: control reaches end
of non-void function
[-Werror,-Wreturn-type]
}
^
/usr/src/sys/sys/amd64/amd64/efirt.c:186:1: error: static declaration of
'efi_create_1t1_map' follows non-static declaration
efi_create_1t1_map(struct efi_md *map, int ndesc, int descsz)
^

There is no sys/amd64/amd64/efirt.c in 11.2 sources.
/usr/src/sys/sys/efi.h:175:6: note: previous declaration is here

Post by a***@WHISPER.SU
bool efi_create_1t1_map(struct efi_md *, int, int);
^
/usr/src/sys/sys/amd64/amd64/efirt.c:441:1: error: no previous prototype
for function
'efi_get_time_locked' [-Werror,-Wmissing-prototypes]
efi_get_time_locked(struct efi_tm *tm)
^
/usr/src/sys/sys/amd64/amd64/efirt.c:463:12: error: use of undeclared
identifier
'resettodr_lock'
mtx_lock(&resettodr_lock);
^
/usr/src/sys/sys/amd64/amd64/efirt.c:465:14: error: use of undeclared
identifier
'resettodr_lock'
mtx_unlock(&resettodr_lock);
^
/usr/src/sys/sys/amd64/amd64/efirt.c:483:1: error: no previous prototype
for function
'efi_set_time_locked' [-Werror,-Wmissing-prototypes]
efi_set_time_locked(struct efi_tm *tm)
^
/usr/src/sys/sys/amd64/amd64/efirt.c:505:12: error: use of undeclared
identifier
'resettodr_lock'
mtx_lock(&resettodr_lock);
^
/usr/src/sys/sys/amd64/amd64/efirt.c:507:14: error: use of undeclared
identifier
'resettodr_lock'
mtx_unlock(&resettodr_lock);
^
8 errors generated.
*** Error code 1
Stop.
make[2]: stopped in /usr/src/sys/modules/efirt
*** Error code 1
Stop.
make[1]: stopped in /usr/src/sys/modules
*** Error code 1
Stop.
make: stopped in /usr/src/sys/amd64/compile/KERNEL
device vga # VGA video card driver
options VESA # Add support for VESA BIOS
Extensions (VBE)
device splash # Splash screen and screen saver
support
# syscons is the default console driver, resembling an SCO console
device sc
options SC_PIXEL_MODE # add support for the raster
text mode
# vt is the new video console driver
device vt
device vt_vga
#device vt_efifb
--
Anatoly
_______________________________________________
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
freebsd.org"

_______________________________________________
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers

Oliver Pinter

2018-07-01 12:28:07 UTC

Permalink

Post by Oliver Pinter

Post by a***@WHISPER.SU
MD5 (./sys/amd64/amd64/efirt.c) = ddc9b6b4e79f12ee8588dbea3d2a010d

Nope: https://github.com/freebsd/freebsd/tree/releng/11.2/sys/amd64/amd64

Neither here:
https://github.com/freebsd/freebsd/tree/release/11.2.0/sys/amd64/amd64

Post by Oliver Pinter

Post by a***@WHISPER.SU

Post by Konstantin Belousov

Post by a***@WHISPER.SU
hi everyone!
Trying to rebuild kernel from 11.1->11.2 RELEASE, till binary update
there was no problem at all with migrations but now im getting following
error building efirt module, tried to google a bit - nothing,
maybe someone already fixed it?
===> efirt (all)
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
-nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include
/usr/src/sys/amd64/compile/KERNEL/opt_global.h -I. -I/usr/src/sys
-fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-I/usr/src/sys/amd64/compile/KERNEL -MD -MF.depend.efirt.o -MTefirt.o
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv
-fstack-protector
-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value
-Wno-error-address-of-packed-member -mno-aes -mno-avx
-std=iso9899:1999
-c /usr/src/sys/sys/amd64/amd64/efirt.c -o efirt.o
/usr/src/sys/sys/amd64/amd64/efirt.c:124:1: error: control reaches end
of non-void function
[-Werror,-Wreturn-type]
}
^
/usr/src/sys/sys/amd64/amd64/efirt.c:186:1: error: static declaration of
'efi_create_1t1_map' follows non-static declaration
efi_create_1t1_map(struct efi_md *map, int ndesc, int descsz)
^

There is no sys/amd64/amd64/efirt.c in 11.2 sources.
/usr/src/sys/sys/efi.h:175:6: note: previous declaration is here

_______________________________________________
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
"

Mark Millard via freebsd-hackers

2018-07-01 13:45:54 UTC

Permalink

On Sunday, July 1, 2018, Oliver Pinter <oliver.pinter at hardenedbsd.org>

Post by Oliver Pinter

Post by a***@WHISPER.SU
MD5 (./sys/amd64/amd64/efirt.c) = ddc9b6b4e79f12ee8588dbea3d2a010d

Nope: https://github.com/freebsd/freebsd/tree/releng/11.2/sys/amd64/amd64

https://github.com/freebsd/freebsd/tree/release/11.2.0/sys/amd64/amd64

Or to reference svn:

https://svnweb.freebsd.org/base/release/11.2.0/sys/amd64/amd64/

shows a efirt_machdep.c but no efirt.c file.

===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)

a***@WHISPER.SU

2018-07-01 15:36:02 UTC

Permalink

yup, just changed svn from svn.freebsd.org to svn0.eu.freebsd.org,
everything is ok. thanks!

Post by Mark Millard via freebsd-hackers

On Sunday, July 1, 2018, Oliver Pinter <oliver.pinter at hardenedbsd.org>

Post by Oliver Pinter

Post by a***@WHISPER.SU
MD5 (./sys/amd64/amd64/efirt.c) = ddc9b6b4e79f12ee8588dbea3d2a010d

Nope: https://github.com/freebsd/freebsd/tree/releng/11.2/sys/amd64/amd64

https://github.com/freebsd/freebsd/tree/release/11.2.0/sys/amd64/amd64

https://svnweb.freebsd.org/base/release/11.2.0/sys/amd64/amd64/
shows a efirt_machdep.c but no efirt.c file.
===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)

Eugene Grosbein

2018-07-01 12:26:03 UTC

Permalink

Post by a***@WHISPER.SU
MD5 (./sys/amd64/amd64/efirt.c) = ddc9b6b4e79f12ee8588dbea3d2a010d

Your local tree got broken somehow. There is no such file in the Repo
but sys/dev/efidev/efirt.c. Delete your /usr/src and fetch it again.